XTC68 C Cross compiler

Anything QL Software or Programming Related.
RWAP
RWAP Master
Posts: 2531
Joined: Sun Nov 28, 2010 4:51 pm
Location: Stone, United Kingdom
Contact:

Re: XTC68 C Cross compiler

Postby RWAP » Wed Oct 31, 2018 12:20 pm

I have moved your changes over - probably an easier way to do it, but I don't know too much about Github - I am just one of the administrators for SinclairQL.

You could of course be a contributor to https://github.com/SinclairQL/xtc68 - I guess you could have created your own pull request?


User avatar
NormanDunbar
Super Gold Card
Posts: 544
Joined: Tue Dec 14, 2010 9:04 am
Location: Leeds, West Yorkshire, UK
Contact:

Re: XTC68 C Cross compiler

Postby NormanDunbar » Wed Oct 31, 2018 1:43 pm

XorA wrote:Who is in charge of SinclairQL/xtc68? We could just push the fix there! I did send a pull request to the original author but that has not been processed!


Interestingly enough, I compared your repository with mine, which was forked from the SinclairQL one, and with the SinclairQL one, and your fix doesn't come up at all, so I applied it manually to my own repository using the commit details in yours.

Weird!


Cheers,
Norm.


Why do they put lightning conductors on churches?
How come Tarzan never grew a beard?
If at first you don't succeed, don't take up skydiving!
If you think your job is pointless, remember, there's a man in Germany who fits indicators on BMWs.
User avatar
XorA
Super Gold Card
Posts: 561
Joined: Thu Jun 02, 2011 11:31 am
Location: Shotts, North Lanarkshire, Scotland, UK

Re: XTC68 C Cross compiler

Postby XorA » Wed Oct 31, 2018 3:33 pm

NormanDunbar wrote:
XorA wrote:Who is in charge of SinclairQL/xtc68? We could just push the fix there! I did send a pull request to the original author but that has not been processed!


Interestingly enough, I compared your repository with mine, which was forked from the SinclairQL one, and with the SinclairQL one, and your fix doesn't come up at all, so I applied it manually to my own repository using the commit details in yours.

Weird!


Cheers,
Norm.


It was in a branch, so you would have needed to pull the branch from mine. As I said I did send a pull request to the original author's github but I guess he lost interest as it was not processed.

Dunderhead me didn't think of sending one to RWAP :-)


User avatar
NormanDunbar
Super Gold Card
Posts: 544
Joined: Tue Dec 14, 2010 9:04 am
Location: Leeds, West Yorkshire, UK
Contact:

Re: XTC68 C Cross compiler

Postby NormanDunbar » Wed Oct 31, 2018 5:26 pm

Aha, that makes sense, thanks.

I did see your pull request on the original author's repo, I was Wondering if xXORAa was you. It seems it was. ;)


Cheers,
Norm.


Why do they put lightning conductors on churches?
How come Tarzan never grew a beard?
If at first you don't succeed, don't take up skydiving!
If you think your job is pointless, remember, there's a man in Germany who fits indicators on BMWs.
User avatar
dilwyn
Mr QL
Posts: 1379
Joined: Wed Dec 01, 2010 10:39 pm
Location: Wales
Contact:

Re: XTC68 C Cross compiler

Postby dilwyn » Wed Oct 31, 2018 8:12 pm

Peter wrote:
XorA wrote:I fixed that bug years ago.

https://github.com/xXorAa/xtc68/tree/fix-stack-smashing

Could this be linked to a website where one would usually look when searching for XTC68?
e.g. http://www.dilwyn.me.uk/c/index.html ? Dilwyn?

Added a link to it from that page.


Dilwyn
All things QL: see www.dilwyn.me.uk
User avatar
NormanDunbar
Super Gold Card
Posts: 544
Joined: Tue Dec 14, 2010 9:04 am
Location: Leeds, West Yorkshire, UK
Contact:

Re: XTC68 C Cross compiler

Postby NormanDunbar » Wed Oct 31, 2018 10:10 pm

Evening Dilwyn,

The link to github is to the original repository by Stronnag (https://github.com/stronnag/xtc68). That version doesn't have XorA's bug fix for the problem with as68's stack trashing error.

It might be worth while, if and when you get some spare time, to link to the version in the SinclairQL repository at https://github.com/SinclairQL/xtc68 which does have the fix applied.

Cheers,
Norm.


Why do they put lightning conductors on churches?
How come Tarzan never grew a beard?
If at first you don't succeed, don't take up skydiving!
If you think your job is pointless, remember, there's a man in Germany who fits indicators on BMWs.
User avatar
dilwyn
Mr QL
Posts: 1379
Joined: Wed Dec 01, 2010 10:39 pm
Location: Wales
Contact:

Re: XTC68 C Cross compiler

Postby dilwyn » Thu Nov 01, 2018 9:57 am

NormanDunbar wrote:Evening Dilwyn,

The link to github is to the original repository by Stronnag (https://github.com/stronnag/xtc68). That version doesn't have XorA's bug fix for the problem with as68's stack trashing error.

It might be worth while, if and when you get some spare time, to link to the version in the SinclairQL repository at https://github.com/SinclairQL/xtc68 which does have the fix applied.

Cheers,
Norm.

Have changed it this morning, but if you get time could you have a quick look to check I've done this the way you meant it to happen, please?


Dilwyn
All things QL: see www.dilwyn.me.uk
User avatar
NormanDunbar
Super Gold Card
Posts: 544
Joined: Tue Dec 14, 2010 9:04 am
Location: Leeds, West Yorkshire, UK
Contact:

Re: XTC68 C Cross compiler

Postby NormanDunbar » Thu Nov 01, 2018 3:40 pm

Thanks very much Dilwyn, that "on github" link now correctly points to the SinclairQL repository.

As Rich recently fixed that codebase to include the stack smashing fix, you can probably get rid of this sentence now. (Sorry!):

An update was done by Graeme Gregory in 2017 to fix a stacking bug - get that update from a Github fork at https://github.com/xXorAa/xtc68/tree/fix-stack-smashing

As the Sinclair QL repo includes Graeme's fix.

As ever, thanks for all you do for us.


Cheers,
Norm.


Why do they put lightning conductors on churches?
How come Tarzan never grew a beard?
If at first you don't succeed, don't take up skydiving!
If you think your job is pointless, remember, there's a man in Germany who fits indicators on BMWs.
User avatar
dilwyn
Mr QL
Posts: 1379
Joined: Wed Dec 01, 2010 10:39 pm
Location: Wales
Contact:

Re: XTC68 C Cross compiler

Postby dilwyn » Thu Nov 01, 2018 9:40 pm

Done, thanks Norman.


Dilwyn
All things QL: see www.dilwyn.me.uk
User avatar
NormanDunbar
Super Gold Card
Posts: 544
Joined: Tue Dec 14, 2010 9:04 am
Location: Leeds, West Yorkshire, UK
Contact:

Re: XTC68 C Cross compiler

Postby NormanDunbar » Thu Nov 01, 2018 9:55 pm

Thanks a lot Dilwyn.

Cheers,
Norm.


Why do they put lightning conductors on churches?
How come Tarzan never grew a beard?
If at first you don't succeed, don't take up skydiving!
If you think your job is pointless, remember, there's a man in Germany who fits indicators on BMWs.

Return to “Software & Programming”

Who is online

Users browsing this forum: No registered users and 2 guests