XTC68 C Cross compiler
-
- RWAP Master
- Posts: 2844
- Joined: Sun Nov 28, 2010 4:51 pm
- Location: Stone, United Kingdom
- Contact:
Re: XTC68 C Cross compiler
I have moved your changes over - probably an easier way to do it, but I don't know too much about Github - I am just one of the administrators for SinclairQL.
You could of course be a contributor to https://github.com/SinclairQL/xtc68 - I guess you could have created your own pull request?
You could of course be a contributor to https://github.com/SinclairQL/xtc68 - I guess you could have created your own pull request?
Rich Mellor
RWAP Software
RWAP Adventures
SellMyRetro
Retro-Printer Module - add a USB printer to your QL
Also Involved in:
Icephorm
RWAP Software
RWAP Adventures
SellMyRetro
Retro-Printer Module - add a USB printer to your QL
Also Involved in:
Icephorm
- NormanDunbar
- Forum Moderator
- Posts: 2285
- Joined: Tue Dec 14, 2010 9:04 am
- Location: Leeds, West Yorkshire, UK
- Contact:
Re: XTC68 C Cross compiler
Interestingly enough, I compared your repository with mine, which was forked from the SinclairQL one, and with the SinclairQL one, and your fix doesn't come up at all, so I applied it manually to my own repository using the commit details in yours.XorA wrote:Who is in charge of SinclairQL/xtc68? We could just push the fix there! I did send a pull request to the original author but that has not been processed!
Weird!
Cheers,
Norm.
Why do they put lightning conductors on churches?
Author of Arduino Software Internals
Author of Arduino Interrupts
No longer on Twitter, find me on https://mastodon.scot/@NormanDunbar.
Author of Arduino Software Internals
Author of Arduino Interrupts
No longer on Twitter, find me on https://mastodon.scot/@NormanDunbar.
- XorA
- Site Admin
- Posts: 1381
- Joined: Thu Jun 02, 2011 11:31 am
- Location: Shotts, North Lanarkshire, Scotland, UK
Re: XTC68 C Cross compiler
It was in a branch, so you would have needed to pull the branch from mine. As I said I did send a pull request to the original author's github but I guess he lost interest as it was not processed.NormanDunbar wrote:Interestingly enough, I compared your repository with mine, which was forked from the SinclairQL one, and with the SinclairQL one, and your fix doesn't come up at all, so I applied it manually to my own repository using the commit details in yours.XorA wrote:Who is in charge of SinclairQL/xtc68? We could just push the fix there! I did send a pull request to the original author but that has not been processed!
Weird!
Cheers,
Norm.
Dunderhead me didn't think of sending one to RWAP
- NormanDunbar
- Forum Moderator
- Posts: 2285
- Joined: Tue Dec 14, 2010 9:04 am
- Location: Leeds, West Yorkshire, UK
- Contact:
Re: XTC68 C Cross compiler
Aha, that makes sense, thanks.
I did see your pull request on the original author's repo, I was Wondering if xXORAa was you. It seems it was.
Cheers,
Norm.
I did see your pull request on the original author's repo, I was Wondering if xXORAa was you. It seems it was.
Cheers,
Norm.
Why do they put lightning conductors on churches?
Author of Arduino Software Internals
Author of Arduino Interrupts
No longer on Twitter, find me on https://mastodon.scot/@NormanDunbar.
Author of Arduino Software Internals
Author of Arduino Interrupts
No longer on Twitter, find me on https://mastodon.scot/@NormanDunbar.
Re: XTC68 C Cross compiler
Added a link to it from that page.Peter wrote:Could this be linked to a website where one would usually look when searching for XTC68?
e.g. http://www.dilwyn.me.uk/c/index.html ? Dilwyn?
--
All things QL - https://dilwyn.qlforum.co.uk/index.html
All things QL - https://dilwyn.qlforum.co.uk/index.html
- NormanDunbar
- Forum Moderator
- Posts: 2285
- Joined: Tue Dec 14, 2010 9:04 am
- Location: Leeds, West Yorkshire, UK
- Contact:
Re: XTC68 C Cross compiler
Evening Dilwyn,
The link to github is to the original repository by Stronnag (https://github.com/stronnag/xtc68). That version doesn't have XorA's bug fix for the problem with as68's stack trashing error.
It might be worth while, if and when you get some spare time, to link to the version in the SinclairQL repository at https://github.com/SinclairQL/xtc68 which does have the fix applied.
Cheers,
Norm.
The link to github is to the original repository by Stronnag (https://github.com/stronnag/xtc68). That version doesn't have XorA's bug fix for the problem with as68's stack trashing error.
It might be worth while, if and when you get some spare time, to link to the version in the SinclairQL repository at https://github.com/SinclairQL/xtc68 which does have the fix applied.
Cheers,
Norm.
Why do they put lightning conductors on churches?
Author of Arduino Software Internals
Author of Arduino Interrupts
No longer on Twitter, find me on https://mastodon.scot/@NormanDunbar.
Author of Arduino Software Internals
Author of Arduino Interrupts
No longer on Twitter, find me on https://mastodon.scot/@NormanDunbar.
Re: XTC68 C Cross compiler
Have changed it this morning, but if you get time could you have a quick look to check I've done this the way you meant it to happen, please?NormanDunbar wrote:Evening Dilwyn,
The link to github is to the original repository by Stronnag (https://github.com/stronnag/xtc68). That version doesn't have XorA's bug fix for the problem with as68's stack trashing error.
It might be worth while, if and when you get some spare time, to link to the version in the SinclairQL repository at https://github.com/SinclairQL/xtc68 which does have the fix applied.
Cheers,
Norm.
--
All things QL - https://dilwyn.qlforum.co.uk/index.html
All things QL - https://dilwyn.qlforum.co.uk/index.html
- NormanDunbar
- Forum Moderator
- Posts: 2285
- Joined: Tue Dec 14, 2010 9:04 am
- Location: Leeds, West Yorkshire, UK
- Contact:
Re: XTC68 C Cross compiler
Thanks very much Dilwyn, that "on github" link now correctly points to the SinclairQL repository.
As Rich recently fixed that codebase to include the stack smashing fix, you can probably get rid of this sentence now. (Sorry!):
An update was done by Graeme Gregory in 2017 to fix a stacking bug - get that update from a Github fork at https://github.com/xXorAa/xtc68/tree/fix-stack-smashing
As the Sinclair QL repo includes Graeme's fix.
As ever, thanks for all you do for us.
Cheers,
Norm.
As Rich recently fixed that codebase to include the stack smashing fix, you can probably get rid of this sentence now. (Sorry!):
An update was done by Graeme Gregory in 2017 to fix a stacking bug - get that update from a Github fork at https://github.com/xXorAa/xtc68/tree/fix-stack-smashing
As the Sinclair QL repo includes Graeme's fix.
As ever, thanks for all you do for us.
Cheers,
Norm.
Why do they put lightning conductors on churches?
Author of Arduino Software Internals
Author of Arduino Interrupts
No longer on Twitter, find me on https://mastodon.scot/@NormanDunbar.
Author of Arduino Software Internals
Author of Arduino Interrupts
No longer on Twitter, find me on https://mastodon.scot/@NormanDunbar.
Re: XTC68 C Cross compiler
Done, thanks Norman.
--
All things QL - https://dilwyn.qlforum.co.uk/index.html
All things QL - https://dilwyn.qlforum.co.uk/index.html
- NormanDunbar
- Forum Moderator
- Posts: 2285
- Joined: Tue Dec 14, 2010 9:04 am
- Location: Leeds, West Yorkshire, UK
- Contact:
Re: XTC68 C Cross compiler
Thanks a lot Dilwyn.
Cheers,
Norm.
Cheers,
Norm.
Why do they put lightning conductors on churches?
Author of Arduino Software Internals
Author of Arduino Interrupts
No longer on Twitter, find me on https://mastodon.scot/@NormanDunbar.
Author of Arduino Software Internals
Author of Arduino Interrupts
No longer on Twitter, find me on https://mastodon.scot/@NormanDunbar.