Page 23 of 23

Re: QL / PASCAL

Posted: Fri Apr 30, 2021 6:41 pm
by NormanDunbar
TT moves in mysterious ways. ;)

Cheers,
Norm.

Re: QL / PASCAL

Posted: Sat May 01, 2021 11:02 am
by Chain-Q
@NormanDunbar
I merged your sysutils patch in r49306. Good job.

The patch you provided also contains the mt_inf() signature change, which I still ignored, for the reasons I explained earlier. ;)

Re: QL / PASCAL

Posted: Sat May 01, 2021 5:43 pm
by Derek_Stewart
Hi,

This maybe a beginners question here, if I apply the the patch locally from a diff file, will svn know this patch has been applied, when an svn update is applied?

Re: QL / PASCAL

Posted: Sat May 01, 2021 7:24 pm
by NormanDunbar
Chain-Q wrote:The patch you provided also contains the mt_inf() signature change, which I still ignored, for the reasons I explained earlier. ;)


Apologies. I could have dworn I fixed that already. Obviously not. I will do so ASAP.


Cheers,
Norm.

Re: QL / PASCAL

Posted: Sat May 01, 2021 7:30 pm
by NormanDunbar
Derek_Stewart wrote: if I apply the the patch locally from a diff file, will svn know this patch has been applied, when an svn update is applied?


If you apply the patch, svn update will not overwrite it. I'veapplied two svn updates since creating the patch.

However, if you apply the patch and someone else updates the code in/around the same lication in the file, you will get a conflict. That will prompt svn patch to prompt you for an action. One option is to view all options. Pick that then choose how to continue from the list.

I've had one conflict (in 6 files) during one svn update. I resolved it by letting the new file overwrite my changes, then checking and re-applying my changes manually -- by retyping. Not the most efficient method, but it worked fine.

When/if Chain-Q merges my changes, a future svn update will apply them to your copy of the official code.

HTH

Cheers,
Norm.

Re: QL / PASCAL

Posted: Mon May 03, 2021 4:06 pm
by Derek_Stewart
Hi Norm,

I have been reading the ebook: Version Control with Subversion, from the Freepascal web site, I can follow the instructions, but still trying understand the concepts.

So much to learn, not enough time to try it all?

Re: QL / PASCAL

Posted: Mon May 03, 2021 4:32 pm
by NormanDunbar
Have fun Derek! ;)

By the way, my latest changes have been merged into the main project:

Chain-Q wrote:NormanDunbar
I merged your sysutils patch in r49306. Good job.


If you run svn update, you'll get them automagically, aslong asthe version number listed at the end is equal orhigher than r49306. (Which will need the new vlink version 16h too.)

Cheers,
Norm.

Re: QL / PASCAL

Posted: Tue May 04, 2021 2:10 pm
by NormanDunbar
Ok, it seems that the RenameFile() function was working correctly. It was my test code that was broken. :( trying to rename a file from 'ram1_before.txt' to 'after.txt' without the 'ram1_' on its name. Duh!

So, RenameFile() is working fine in that it:

  • Renames a file correctly.
  • Fails to rename if the "to" filename is invalid.
  • Fails to rename if the "to" filename already exists.
  • Fails to rename if the "to" filename is on a different device.


So, the code in FPC.patch.7.zip which included this function, is valid and works fine. As previously mentioned by Chain-Q, I'd neglected to revert back the function header for MT_INF in qdos.inc. The latest update (run svn info) which is version 49335, has that already applied. So, if svn info gives you a revision number less than that, run svn update to pull in the latest code.



Cheers,
Norm.

Re: QL / PASCAL

Posted: Tue May 04, 2021 6:24 pm
by Chain-Q
Norman, the FPC_patch.8.zip you attached only contains a 0 bytes file. Is this intentional?

Re: QL / PASCAL

Posted: Tue May 04, 2021 7:52 pm
by NormanDunbar
Interesting!

I removed the attachment after finding that the latest revision already fixed mt_inf's parameter types and came up with zero changes. I wonder why it's back again.

Attempting a further removal......done, it is gone properly now.

Cheers,
Norm.