Page 2 of 2

Re: SMSQ/E Source Reading

Posted: Thu Apr 25, 2019 3:51 pm
by NormanDunbar
Hi Marcel,

I disagree on it being hard to read. I agree, it doesn't read like a good book, or perhaps, some higher level languages, but in the main, I find it "not too bad" to read. Having said that, I get annoyed/confused/whatever with the use of really short labels what are pretty much like something out of the Armed Forces! I like to use meaningful names myself - ok, mostly - but I seem to remember TT likes the really short stuff. (As an example of what I find hard about his code.)

Anyway, as I said in my original post, it's probably me that's at fault.

EDIT: Yup, I just had a quick look in SMSQ 3.34 and it is the short names that wind me up about reading Tony's code. Told you it was me!


Cheers,
Norm.

Re: SMSQ/E Source Reading

Posted: Thu Apr 25, 2019 4:17 pm
by mk79
NormanDunbar wrote:I disagree on it being hard to read. I agree, it doesn't read like a good book, or perhaps, some higher level languages, but in the main, I find it "not too bad" to read.
As somebody who has read, written and foremost debugged hundreds of thousands of lines of assembler I still disagree ;)
Having said that, I get annoyed/confused/whatever with the use of really short labels what are pretty much like something out of the Armed Forces!
It's only a "relatively" recent development that assemblers processed more than 8 character per label (i.e. QMAC vs GST).

Marcel

Re: SMSQ/E Source Reading

Posted: Thu Apr 25, 2019 5:25 pm
by pjw
NormanDunbar wrote:EDIT: Yup, I just had a quick look in SMSQ 3.34 and it is the short names that wind me up about reading Tony's code. Told you it was me!
With 230000 lines of code you need to keep labels short so as not to wear down your fingers.. To my mind, SMSQ/E's labels are neat and logical, and help to visualise the design! Labels that are so long you have to READ them, rather than just LOOK at and recognise them, are not sexy, IMHO, just messy and noisy.

Re: SMSQ/E Source Reading

Posted: Thu Apr 25, 2019 6:50 pm
by Dave
mk79 wrote:
Dave wrote:Strip out the microdrive code and that leaves 12 lines :P
Considering that there is no MDV driver in SMSQ/E I find this highly unlikely ;)


mk79 wrote:
Derek Stewpot wrote:I am sure I used Super Gold Card with SMSQ/E and the microdrives worked. I think this was about version 2.76.

Your memory might be playing tricks here, MDV drivers were never part of SMSQ/E. Trust me on this, I happen to know that code.


Looks like I'm keeping good company then :P