Page 2 of 4
Re: XTC68 C Cross compiler
Posted: Wed Oct 31, 2018 12:20 pm
by RWAP
I have moved your changes over - probably an easier way to do it, but I don't know too much about Github - I am just one of the administrators for SinclairQL.
You could of course be a contributor to
https://github.com/SinclairQL/xtc68 - I guess you could have created your own pull request?
Re: XTC68 C Cross compiler
Posted: Wed Oct 31, 2018 1:43 pm
by NormanDunbar
XorA wrote:Who is in charge of SinclairQL/xtc68? We could just push the fix there! I did send a pull request to the original author but that has not been processed!
Interestingly enough, I compared your repository with mine, which was forked from the SinclairQL one, and with the SinclairQL one, and your fix doesn't come up at all, so I applied it manually to my own repository using the commit details in yours.
Weird!
Cheers,
Norm.
Re: XTC68 C Cross compiler
Posted: Wed Oct 31, 2018 3:33 pm
by XorA
NormanDunbar wrote:XorA wrote:Who is in charge of SinclairQL/xtc68? We could just push the fix there! I did send a pull request to the original author but that has not been processed!
Interestingly enough, I compared your repository with mine, which was forked from the SinclairQL one, and with the SinclairQL one, and your fix doesn't come up at all, so I applied it manually to my own repository using the commit details in yours.
Weird!
Cheers,
Norm.
It was in a branch, so you would have needed to pull the branch from mine. As I said I did send a pull request to the original author's github but I guess he lost interest as it was not processed.
Dunderhead me didn't think of sending one to RWAP
Re: XTC68 C Cross compiler
Posted: Wed Oct 31, 2018 5:26 pm
by NormanDunbar
Aha, that makes sense, thanks.
I did see your pull request on the original author's repo, I was Wondering if xXORAa was you. It seems it was.
Cheers,
Norm.
Re: XTC68 C Cross compiler
Posted: Wed Oct 31, 2018 8:12 pm
by dilwyn
Added a link to it from that page.
Re: XTC68 C Cross compiler
Posted: Wed Oct 31, 2018 10:10 pm
by NormanDunbar
Evening Dilwyn,
The link to github is to the original repository by Stronnag (
https://github.com/stronnag/xtc68). That version doesn't have XorA's bug fix for the problem with as68's stack trashing error.
It might be worth while, if and when you get some spare time, to link to the version in the SinclairQL repository at
https://github.com/SinclairQL/xtc68 which does have the fix applied.
Cheers,
Norm.
Re: XTC68 C Cross compiler
Posted: Thu Nov 01, 2018 9:57 am
by dilwyn
NormanDunbar wrote:Evening Dilwyn,
The link to github is to the original repository by Stronnag (
https://github.com/stronnag/xtc68). That version doesn't have XorA's bug fix for the problem with as68's stack trashing error.
It might be worth while, if and when you get some spare time, to link to the version in the SinclairQL repository at
https://github.com/SinclairQL/xtc68 which does have the fix applied.
Cheers,
Norm.
Have changed it this morning, but if you get time could you have a quick look to check I've done this the way you meant it to happen, please?
Re: XTC68 C Cross compiler
Posted: Thu Nov 01, 2018 3:40 pm
by NormanDunbar
Thanks very much Dilwyn, that "on github" link now correctly points to the SinclairQL repository.
As Rich recently fixed that codebase to include the stack smashing fix, you can probably get rid of this sentence now. (Sorry!):
An update was done by Graeme Gregory in 2017 to fix a stacking bug - get that update from a Github fork at https://github.com/xXorAa/xtc68/tree/fix-stack-smashing
As the Sinclair QL repo includes Graeme's fix.
As ever, thanks for all you do for us.
Cheers,
Norm.
Re: XTC68 C Cross compiler
Posted: Thu Nov 01, 2018 9:40 pm
by dilwyn
Done, thanks Norman.
Re: XTC68 C Cross compiler
Posted: Thu Nov 01, 2018 9:55 pm
by NormanDunbar
Thanks a lot Dilwyn.
Cheers,
Norm.