SMSQ/E sources - mirror git repository

Anything QL Software or Programming Related.
User avatar
M68008
Bent Pin Expansion Port
Posts: 78
Joined: Sat Jan 29, 2011 1:55 am
Contact:

SMSQ/E sources - mirror git repository

Postby M68008 » Sat May 19, 2018 8:39 pm

I've downloaded all the old public versions of the SMSQ/E sources that are available on the official SMSQ/E web site and added them to GitHub:

https://github.com/CodeDreamer/SMSQE

This makes it easier to compare the sources for different versions. I hope that the official sources can also move to source control at some point as that has obvious advantages compared to the current method.

Daniele


RWAP
RWAP Master
Posts: 2615
Joined: Sun Nov 28, 2010 4:51 pm
Location: Stone, United Kingdom
Contact:

Re: SMSQ/E sources - mirror git repository

Postby RWAP » Sat May 19, 2018 8:52 pm

Thanks Daniele, I have forked it into the Sinclair QL github too - https://github.com/SinclairQL/SMSQE


Derek_Stewart
QL Wafer Drive
Posts: 1394
Joined: Mon Dec 20, 2010 11:40 am
Location: Runcorn, Cheshire, UK

Re: SMSQ/E sources - mirror git repository

Postby Derek_Stewart » Sun May 20, 2018 9:43 am

Hi,

There is no real need to do this, as Wolfgang has a page with all the old versions of SMSQ/E at:

http://www.wlenerz.com/smsqe/oldversions.html


Regards,

Derek
RWAP
RWAP Master
Posts: 2615
Joined: Sun Nov 28, 2010 4:51 pm
Location: Stone, United Kingdom
Contact:

Re: SMSQ/E sources - mirror git repository

Postby RWAP » Sun May 20, 2018 10:21 am

We know - but the benefit of the github is that it makes it easy to see what has changed between versions.

Then when something no longer works as expected, you can see what changed easily!


User avatar
pjw
Super Gold Card
Posts: 526
Joined: Fri Jul 11, 2014 8:44 am
Location: Norway
Contact:

Re: SMSQ/E sources - mirror git repository

Postby pjw » Sun May 20, 2018 10:58 am

Is the Registrar aware of this move? Were any of the copyright holders asked, or even informed of this in advance? (I know I wasnt) Apart from the possible convenience, what are the implications, positive or negative? Hmm..


Per
Be wary of large West-Coast corporations bearing gifts!
- Ancient Trojan proverb
Derek_Stewart
QL Wafer Drive
Posts: 1394
Joined: Mon Dec 20, 2010 11:40 am
Location: Runcorn, Cheshire, UK

Re: SMSQ/E sources - mirror git repository

Postby Derek_Stewart » Sun May 20, 2018 7:38 pm

Hi,

I do not think this breaks of the SMSQ/E Licence and personally I am not too bothered.

But I think notice should of be given to the SMSQ/E Registrar of the proposed action with regards to the SMSQ/E source on Git Hub.

Having been on the wrong of the SMSQ/E Licence in the production of the Q60 and was subjected to alot unwarranted criticism. I would not want this sort thing to happen again.


Regards,

Derek
User avatar
tofro
QL Wafer Drive
Posts: 1585
Joined: Sun Feb 13, 2011 10:53 pm
Location: SW Germany

Re: SMSQ/E sources - mirror git repository

Postby tofro » Sun May 20, 2018 7:58 pm

Obviously, holding the sources in now 3 (!) different places (it is absolutely not clear to me why it needs to be on GitHub twice, btw) holds the danger of splitting SMSQ/E development into various branches, especially when people don't know where the master is stored. I don't even dare to think what pitfalls are opened when code is checked in into one repository and not in another.

If your intent was to simply be able to diff various versions against each other, it would make sense to point this out somewhere in the README (can't see that as of today) and make it very clear that the authoritative repository is with Wolfgang. It would also make sense to point out that the volunteer maintainers are not working on the GitHub branches.

Tobias
Last edited by tofro on Sun May 20, 2018 8:06 pm, edited 1 time in total.


ʎɐqǝ ɯoɹɟ ǝq oʇ ƃuᴉoƃ ʇou sᴉ pɹɐoqʎǝʞ ʇxǝu ʎɯ 'ɹɐǝp ɥO
User avatar
XorA
Super Gold Card
Posts: 593
Joined: Thu Jun 02, 2011 11:31 am
Location: Shotts, North Lanarkshire, Scotland, UK

Re: SMSQ/E sources - mirror git repository

Postby XorA » Sun May 20, 2018 8:05 pm

pjw wrote:Is the Registrar aware of this move? Were any of the copyright holders asked, or even informed of this in advance? (I know I wasnt) Apart from the possible convenience, what are the implications, positive or negative? Hmm..


The license you chose for your work says you don't care as long as your name is retained.


User avatar
vezhlys
ROM Dongle
Posts: 25
Joined: Sun Sep 03, 2017 8:45 am

Re: SMSQ/E sources - mirror git repository

Postby vezhlys » Sun May 20, 2018 9:23 pm

tofro wrote:Obviously, holding the sources in now 3 (!) different places (it is absolutely not clear to me why it needs to be on GitHub twice, btw) holds the danger of splitting SMSQ/E development into various branches, especially when people don't know where the master is stored. I don't even dare to think what pitfalls are opened when code is checked in into one repository and not in another.

If your intent was to simply be able to diff various versions against each other, it would make sense to point this out somewhere in the README (can't see that as of today) and make it very clear that the authoritative repository is with Wolfgang. It would also make sense to point out that the volunteer maintainers are not working on the GitHub branches.

Tobias


I think proper README.md and licence files should be enough (and it is already done as I can see). I wouldn't be afraid of somebody working on it and several mirrors is not an issue as well. It's quite unlikely for random person to start development on it without any background on what he is working on. Finally, he won't be able to submit any changes, so eventually he will be forced to find out the original source anyway. Even if somebody would decide to split development, he would need support from community, otherwise it will stay as his own pet project. Finally such practice is being used in other open source projects. For example, NetBSD main repository still uses cvs but you can find git, fossil counterparts "automatically" migrated every day (partly official and not). It actually very convenient, not confusing at all (you decide yourself what is the most convenient way to get the sources). Just hope it will be maintained :).


User avatar
NormanDunbar
Super Gold Card
Posts: 730
Joined: Tue Dec 14, 2010 9:04 am
Location: Leeds, West Yorkshire, UK
Contact:

Re: SMSQ/E sources - mirror git repository

Postby NormanDunbar » Sun May 20, 2018 9:30 pm

The official site has the licence, which states:

LICENCE FOR SMSQ/E

Copyright (c) 1989-2012, by
Tony Tebby
Marcel Kilgus
Bruno Coativy
Fabrizio Diversi
Phoebus Dokos
Thierry Godefroy
Jérôme Grimbert
George Gwilt
John Hall
Mark Swift
Per Witte
Wolfgang Lenerz
collectively called the "COPYRIGHT HOLDERS".
All rights reserved.

Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.
Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.


So, as long as the copyright stays intact, it should be ok on github. (I have not reproduced the fisclaimer here.)

But, the actual licence is held in the source archive itself, and is the one to follow.

HTH

Norm.


Why do they put lightning conductors on churches?
If at first you don't succeed, don't take up skydiving!
If you think your job is pointless, remember, there's someone in Germany who fits indicators to BMWs.

Who is online

Users browsing this forum: No registered users and 4 guests